Feat #712 + #711 : Developer can see a list of enpoints and a graph showing my ‘Hits per Day’ #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/712-developer-can-see-list-of-enpoints
…eat/712-developer-can-see-list-of-enpoints
…/reapit/foundations into feat/712-developer-can-see-list-of-enpoints
github-actions
bot
requested review from
leXuanNha,
phmngocnghia,
duong-se,
trankhacvy,
vuhuucuong and
willmcvay
github-actions
bot
added
elements
nphivu414
commented
Apr 7, 2020
| @@ -54,7 +54,7 @@ | |||
| "react-google-map": "^3.1.1", | |||
| "react-google-maps-loader": "^4.2.5", | |||
| "react-icons": "^3.7.0", | |||
| "react-table": "7.0.0-alpha.35", | |||
| "react-table": "7.0.4", | |||
There was a problem hiding this comment.
Upgrade to stable version of react-table to add Footer to the table
https://react-table.js.org/examples/simple#footers
Version 7.0.0-alpha.35 didn't have this feature.
phmngocnghia
approved these changes
Apr 7, 2020
nphivu414
pushed a commit
that referenced
this pull request
Apr 29, 2020
…howing my ‘Hits per Day’ (#836) * mock redux * mock redux * feat: #712: Add traffic event table component * feat: #712: Upgrade react-table to stable version - Add Footer for table element * fixing typescript * feat: #712: Update developer endpoint list + chart * feat: #712: Fix typo issues * feat: #712: Fix linting issues * feat: #712: Fix linting issues * feat: #712: Update snapshot test Co-authored-by: nhalx <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.