Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #739 correct logic #809

Merged
merged 1 commit into from
Apr 3, 2020
Merged

fix: #739 correct logic #809

merged 1 commit into from
Apr 3, 2020

Conversation

vuhuucuong
Copy link
Contributor

Correct check window.REAPIT_MARKETPLACE_GLOBALS writable logic

@github-actions github-actions bot added the elements Relates to Elements components and utilities label Apr 3, 2020
@vuhuucuong vuhuucuong merged commit f9d7f3a into master Apr 3, 2020
@vuhuucuong vuhuucuong deleted the fix/739-correct-logic branch April 3, 2020 10:43
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
fix: #739 correcr logic before restore window.__REAPIT_MARKETPLACE_GL…
c4143d6 
…OBALS__ (#809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nphivu414 nphivu414 nphivu414 approved these changes

@trankhacvy trankhacvy trankhacvy approved these changes

@leXuanNha leXuanNha Awaiting requested review from leXuanNha

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@duong-se duong-se Awaiting requested review from duong-se

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@vuhuucuong vuhuucuong

Labels
elements Relates to Elements components and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vuhuucuong @trankhacvy @nphivu414