Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #568 add more config to scaffolder and fix private route wrapper for check isFetching or not #775

Merged
merged 1 commit into from
Apr 1, 2020
Merged

fix: #568 add more config to scaffolder and fix private route wrapper for check isFetching or not #775

merged 1 commit into from
Apr 1, 2020

Conversation

duong-se
Copy link
Contributor

Changes

  • Add config to config.json of scaffolder
  • Fix private route router
  • Add isFetchSession for cognito flow

fix: #568 add more config to scaffolder
2eade6b 
Changes
- Add config to config.json of scaffolder
@github-actions github-actions bot added the react-app-scaffolder Relates to React App Scaffolder package label Mar 31, 2020
@duong-se duong-se changed the title fix: #568 add more config to scaffolder fix: #568 add more config to scaffolder and fix private route wrapper for check isFetching or not Mar 31, 2020
vuhuucuong
vuhuucuong approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 01ead39 into master Apr 1, 2020
@duong-se duong-se deleted the fix/568-add-more-config-to-scaffolder branch April 1, 2020 05:49
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
fix: #568 add more config to scaffolder (#775)
4e11a48 
Changes
- Add config to config.json of scaffolder
- Fix check isFetching or not in private route wrapper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@nphivu414 nphivu414 nphivu414 approved these changes

@leXuanNha leXuanNha Awaiting requested review from leXuanNha

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@duong-se duong-se

Labels
react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duong-se @nphivu414 @vuhuucuong