Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #654 Implement Toast component #703

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Conversation

trankhacvy
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the elements Relates to Elements components and utilities label Mar 24, 2020
duration,
closable: true,
onClose: args.onClose,
// onClick: args.onClick,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a temporary comment?

@github-actions github-actions bot requested a review from duong-se March 24, 2020 03:06
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for 2 comments above, others LGTM

@trankhacvy trankhacvy force-pushed the feat/654-The-Toast-Component branch from 6895aa1 to c77b1a9 Compare March 24, 2020 08:28
@github-actions github-actions bot requested a review from duong-se March 24, 2020 08:28
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trankhacvy trankhacvy merged commit 6ffae07 into master Mar 24, 2020
@trankhacvy trankhacvy deleted the feat/654-The-Toast-Component branch March 24, 2020 10:21
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
* feat: #654 Implement Toast component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elements Relates to Elements components and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants