Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #681 bug after migrate config marketplace #696

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix: #681 bug after migrate config marketplace #696

merged 1 commit into from
Mar 23, 2020

Conversation

duong-se
Copy link
Contributor

Changes

  • Migrate process.env.CHAT_BOT_APP_ID to window.reapit.config.chatbotAppId

@github-actions github-actions bot added cognito-auth Issue relates to Cognito Auth NPM package marketplace Relates to the Marketplace react-app-scaffolder Relates to React App Scaffolder package labels Mar 23, 2020
fix: #681 bug live chat after migrate to config.json
967e2b9 
Changes
- Change chatbot App ID from process.env to window.reapit.config
@duong-se duong-se force-pushed the fix/681-bug-after-migrate-config-marketplace branch from 802f738 to 967e2b9 Compare March 23, 2020 12:56
willmcvay
willmcvay approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@duong-se duong-se merged commit 0bad466 into master Mar 23, 2020
@duong-se duong-se deleted the fix/681-bug-after-migrate-config-marketplace branch March 23, 2020 13:24
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
fix: #681 bug live chat after migrate to config.json (#696)
576b2e7 
Changes
- Change chatbot App ID from process.env to window.reapit.config
This was referenced Dec 2, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@willmcvay willmcvay willmcvay approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@duong-se duong-se

Labels
cognito-auth Issue relates to Cognito Auth NPM package marketplace Relates to the Marketplace react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duong-se @willmcvay @phmngocnghia