Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #568 react scaffold bug fixing after migration to config.json #693

Merged
merged 1 commit into from
Mar 23, 2020
Merged

fix: #568 react scaffold bug fixing after migration to config.json #693

merged 1 commit into from
Mar 23, 2020

Conversation

duong-se
Copy link
Contributor

Changes

  • Add export default app.tsx
  • Change index.tsx to remove import index.scss
  • Add cognitoUserPoolId for config.json

@github-actions github-actions bot added aml-checklist Relates to Anti-money laundering app cognito-auth Issue relates to Cognito Auth NPM package geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace react-app-scaffolder Relates to React App Scaffolder package labels Mar 23, 2020
@duong-se duong-se force-pushed the fix/568-react-scaffold-bug branch from 6fa76cc to e75eab6 Compare March 23, 2020 08:48
@duong-se duong-se changed the title fix: #568 react scaffold after migration to config.json fix: #568 react scaffold bug fixing after migration to config.json Mar 23, 2020
vuhuucuong
vuhuucuong approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@duong-se duong-se force-pushed the fix/568-react-scaffold-bug branch from e75eab6 to 0fbf0b1 Compare March 23, 2020 09:21
@github-actions github-actions bot requested a review from vuhuucuong March 23, 2020 09:21
fix: #568 react scaffold after migration to config.json
33d4d9a 
Changes
- Add export default app.tsx
- Change index.tsx to remove import index.scss
@duong-se duong-se force-pushed the fix/568-react-scaffold-bug branch from 0fbf0b1 to 33d4d9a Compare March 23, 2020 09:55
@duong-se duong-se merged commit 0fb24fb into master Mar 23, 2020
@duong-se duong-se deleted the fix/568-react-scaffold-bug branch March 23, 2020 10:25
@phmngocnghia phmngocnghia mentioned this pull request Apr 28, 2020
Merged
phmngocnghia pushed a commit that referenced this pull request Apr 28, 2020
fix: #693 - increase webhooks page dropdown size, and load developer …
7cb3f6f 
…apps data
phmngocnghia pushed a commit that referenced this pull request Apr 28, 2020
fix: #693 - increase webhooks page dropdown size, and load developer …
5688d6f 
…apps data (#1095)
@phmngocnghia phmngocnghia mentioned this pull request Apr 29, 2020
Merged
willmcvay pushed a commit that referenced this pull request Apr 29, 2020
fix: #693 - increase webhooks page dropdown size, and load developer …
f6d395a 
…apps data (#1095)
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
fix: #568 react scaffold after migration to config.json (#693)
47f00e3 
Changes
- Add export default app.tsx
- Change index.tsx to remove import index.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@duong-se duong-se

Labels
aml-checklist Relates to Anti-money laundering app cognito-auth Issue relates to Cognito Auth NPM package geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App marketplace Relates to the Marketplace react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duong-se @vuhuucuong @phmngocnghia