Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#73: Create query to populate users table smb #570

Merged
merged 10 commits into from
Mar 11, 2020
Merged

#73: Create query to populate users table smb #570

merged 10 commits into from
Mar 11, 2020

Conversation

nphivu414
Copy link
Contributor

No description provided.

@github-actions github-actions bot added elements Relates to Elements components and utilities graphql-server smb-onboarder Relates to Small Medium Business onboarding app labels Mar 10, 2020
@nphivu414 nphivu414 linked an issue Mar 10, 2020 that may be closed by this pull request
Create Query to populate 'Users' table in SMB App #73
Closed
@duong-se
Copy link
Contributor

I think should use negotiators term instead of the user, it'll cause confusion when we read the code

willmcvay
willmcvay approved these changes Mar 10, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will need to address failing test

@github-actions github-actions bot requested a review from willmcvay March 11, 2020 02:41
duong-se
duong-se approved these changes Mar 11, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nphivu414 nphivu414 merged commit 11e8fef into master Mar 11, 2020
@nphivu414 nphivu414 deleted the feat/73-create-query-to-populate-users-table-smb branch March 11, 2020 04:19
nphivu414 pushed a commit that referenced this pull request Apr 29, 2020
#73: Create query to populate users table smb (#570)
4927c81 
* feat: #73 - Create query to populate users table
@willmcvay willmcvay mentioned this pull request Mar 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@dannd4 dannd4 Awaiting requested review from dannd4

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@nphivu414 nphivu414

Labels
elements Relates to Elements components and utilities graphql-server smb-onboarder Relates to Small Medium Business onboarding app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Query to populate 'Users' table in SMB App
3 participants
@nphivu414 @duong-se @willmcvay