Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #2628 - add PersistantNotification component, stories and tests #3921

Merged
merged 3 commits into from
Apr 9, 2021
Merged

feat: #2628 - add PersistantNotification component, stories and tests #3921

merged 3 commits into from
Apr 9, 2021

Conversation

jblok
Copy link
Contributor

@jblok jblok commented Apr 9, 2021

@github-actions github-actions bot added the elements Relates to Elements components and utilities label Apr 9, 2021
@github-actions github-actions bot closed this Apr 9, 2021
github-actions[bot]
github-actions bot reviewed Apr 9, 2021
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request since the title does not match ^(?:(?:[WIP] ?)?(?:build|ci|chore|docs|feat|fix|perf|refactor|revert|style|test):(?:\ +?#\d+?\ +?)?.)|(?:[Snyk].) pattern. Please fix the title and re-open the pull request.

@jblok jblok changed the title add PersistantNotification component, stories and tests feat: #2628 - add PersistantNotification component, stories and tests Apr 9, 2021
@jblok jblok reopened this Apr 9, 2021
willmcvay
willmcvay approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@jblok jblok merged commit 65f139e into master Apr 9, 2021
@jblok jblok deleted the feat/#2628-elementsv3-notifications branch April 9, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@willmcvay willmcvay willmcvay approved these changes

Assignees
No one assigned
Labels
elements Relates to Elements components and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jblok @willmcvay