Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #2576 update direct debit flow on billing #2608

Merged
merged 3 commits into from
Sep 9, 2020
Merged

fix: #2576 update direct debit flow on billing #2608

merged 3 commits into from
Sep 9, 2020

Conversation

vuhuucuong
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2576

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2576

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested review from duong-se and trankhacvy September 8, 2020 09:27
@vuhuucuong vuhuucuong force-pushed the fix/2576-update-direct-debit-flow-on-billing branch from 6071173 to 64105a9 Compare September 8, 2020 09:28
@github-actions github-actions bot requested review from ant066 and willmcvay September 8, 2020 09:29
@vuhuucuong vuhuucuong changed the title fix: #2576 update direct debit flow on billing fix: #2576 [WIP] update direct debit flow on billing Sep 8, 2020
@vuhuucuong vuhuucuong changed the title fix: #2576 [WIP] update direct debit flow on billing [WIP] fix: #2576 update direct debit flow on billing Sep 8, 2020
@vuhuucuong vuhuucuong changed the title [WIP] fix: #2576 update direct debit flow on billing fix: #2576 update direct debit flow on billing Sep 8, 2020
duong-se
duong-se approved these changes Sep 9, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuhuucuong vuhuucuong merged commit 562fdd1 into master Sep 9, 2020
@vuhuucuong vuhuucuong deleted the fix/2576-update-direct-debit-flow-on-billing branch September 9, 2020 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@duong-se duong-se duong-se approved these changes

@nphivu414 nphivu414 nphivu414 approved these changes

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@ant066 ant066 Awaiting requested review from ant066

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@vuhuucuong vuhuucuong

Labels
developer-portal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the ‘Direct Debit’ flow on ‘Billing’
4 participants
@vuhuucuong @nphivu414 @duong-se @phmngocnghia