Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2579 unprotect routes #2605

Merged
merged 2 commits into from
Sep 8, 2020
Merged

fix: #2579 unprotect routes #2605

merged 2 commits into from
Sep 8, 2020

Conversation

willmcvay
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2579

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2579

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@ant066 ant066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 17791c8 into master Sep 8, 2020
@duong-se duong-se deleted the fix/#2579-unprotect-routes branch September 8, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is impossible to accept an organisation invite without a user session
3 participants