Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #2553 cleanup all sentry error #2573

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

vuhuucuong
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2553

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2553

What is the new behavior?

  • Fix this type of errors. Remove all logger because we already have that in services files
    1

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vuhuucuong vuhuucuong merged commit 808bda4 into master Sep 4, 2020
@vuhuucuong vuhuucuong deleted the chore/2553-cleanup-sentry-error branch September 4, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clean up sentry error
4 participants