Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #2451 land on page not found bug #2462

Merged
merged 1 commit into from
Aug 25, 2020
Merged

fix: #2451 land on page not found bug #2462

merged 1 commit into from
Aug 25, 2020

Conversation

duong-se
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2451

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2451

What is the new behavior?

  • Land on page not found

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested a review from vuhuucuong August 25, 2020 05:25
@duong-se duong-se force-pushed the fix/2451-land-on-page-not-found branch from dbb6463 to 6c60929 Compare August 25, 2020 05:34
@github-actions github-actions bot requested a review from phmngocnghia August 25, 2020 05:34
@duong-se duong-se merged commit 0d41e8d into master Aug 25, 2020
@duong-se duong-se deleted the fix/2451-land-on-page-not-found branch August 25, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant066 ant066 ant066 approved these changes

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@willmcvay willmcvay Awaiting requested review from willmcvay

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

Assignees

@duong-se duong-se

Labels
admin-portal developer-portal marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Land on page not found after login
3 participants
@duong-se @vuhuucuong @ant066