fix: #213 redirect correct page when access with path '/' #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
phmngocnghia,
duong-se,
trankhacvy,
vuhuucuong,
willmcvay and
zlatanpham
willmcvay
requested changes
Feb 11, 2020
| switch (loginType) { | ||
| case 'ADMIN': | ||
| return Routes.ADMIN_APPROVALS | ||
| case 'DEVELOPER': |
There was a problem hiding this comment.
You need to catch the case where the first login cookie was not present - see getDefaultRouteByLoginType in same file.
Also, needs a test
dannd4
force-pushed
the
fix/213-fix-not-found-page
branch
from
5bd507c to
0190436
Compare
dannd4
force-pushed
the
fix/213-fix-not-found-page
branch
from
0190436 to
59f7b57
Compare
nphivu414
pushed a commit
that referenced
this pull request
Apr 29, 2020
* [CLD-588] view authentication flow in app detail * [CLD-588] Fix comments * [CLD-588] Fix comments and upgrade elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.