Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2023 tweaks to go live with NPM #2244

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Conversation

willmcvay
Copy link
Contributor

@willmcvay willmcvay commented Jul 31, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #2023

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2023

What is the new behavior?

  • Updates docs links and bumps versions

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from nphivu414 and duong-se July 31, 2020 13:48
@github-actions github-actions bot added cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities react-app-scaffolder Relates to React App Scaffolder package labels Jul 31, 2020
@auto-assign auto-assign bot requested a review from vuhuucuong July 31, 2020 13:49
@willmcvay willmcvay changed the title fix: tweaks to go live with NPM fix: #2023 tweaks to go live with NPM Jul 31, 2020
@willmcvay willmcvay merged commit 8afc7ab into master Jul 31, 2020
@willmcvay willmcvay deleted the feat/#2023-prod-tweaks branch July 31, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities react-app-scaffolder Relates to React App Scaffolder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRA template tweaks and tidy up for full production
1 participant