Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2023 NPM packages v1.0.0 #2234

Merged
merged 2 commits into from
Jul 31, 2020
Merged

Conversation

willmcvay
Copy link
Contributor

@willmcvay willmcvay commented Jul 30, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #2023

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2023

What is the new behavior?

  • Bumps Elements version to v1.0.0 for release
  • Deprecates Cognito Auth
  • Deprecates Scaffolder for external users
  • CRA template tidy up and tweaks for full prod v1.0.0 release
  • Connect session version 1.0.0 for full release

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from duong-se and trankhacvy July 30, 2020 19:14
@github-actions github-actions bot added the cognito-auth Issue relates to Cognito Auth NPM package label Jul 30, 2020
@auto-assign auto-assign bot requested a review from nphivu414 July 30, 2020 19:17
}
}, [connectSession])

console.log('Appointment Config Types are: ', appointmentConfigTypes)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove console ?

@@ -1,3 +1,5 @@
@import url('https://fonts.googleapis.com/css?family=Roboto&display=swap');

@import "~@reapit/elements/dist/index.css"

Copy link
Contributor

@duong-se duong-se Jul 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you remove this space?

@@ -1,4 +1,5 @@
@import url('https://fonts.googleapis.com/css?family=Roboto&display=swap');
@import "~@reapit/elements/dist/index.css";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove space

@duong-se duong-se merged commit 2194447 into master Jul 31, 2020
@duong-se duong-se deleted the feat/#2023-npm-packages-prod branch July 31, 2020 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cognito-auth Issue relates to Cognito Auth NPM package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CRA template tweaks and tidy up for full production
3 participants