Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2174 Coming soon section spacing fix #2207

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Conversation

vuhuucuong
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2174 comment

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2174
image

What is the new behavior?

  • Correct spacing between main app and coming soon section
    image

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from nphivu414 and willmcvay July 29, 2020 04:55
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jul 29, 2020
@auto-assign auto-assign bot requested review from phmngocnghia and duong-se July 29, 2020 04:56
@vuhuucuong vuhuucuong closed this Jul 29, 2020
@vuhuucuong vuhuucuong changed the title feat: #2174 wip validation coming soon section feat: #2174 Coming soon section spacing fix Jul 29, 2020
@vuhuucuong vuhuucuong reopened this Jul 29, 2020
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuhuucuong vuhuucuong merged commit 5fa16fc into master Jul 29, 2020
@vuhuucuong vuhuucuong deleted the fix/2174-spacing-fix branch July 29, 2020 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a ‘Coming Soon’ section on the Marketplace ‘Browse’ page
3 participants