Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2174 coming soon section in marketplace #2197

Merged
merged 2 commits into from
Jul 28, 2020

Conversation

vuhuucuong
Copy link
Contributor

@vuhuucuong vuhuucuong commented Jul 28, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #2174

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2174

What is the new behavior?

  • Add coming soon section in marketplace
    image

Does this introduce a breaking change?

  • Yes
  • No

Other information

@vuhuucuong vuhuucuong force-pushed the feat/2174-coming-sson-section-marketplace branch from 8377340 to 7ba09a5 Compare July 28, 2020 06:34
@github-actions github-actions bot requested review from ant066 and duong-se July 28, 2020 06:34
@github-actions github-actions bot requested a review from nphivu414 July 28, 2020 06:34
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jul 28, 2020
@auto-assign auto-assign bot requested a review from willmcvay July 28, 2020 06:34
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vuhuucuong vuhuucuong merged commit dbbce5b into master Jul 28, 2020
@vuhuucuong vuhuucuong deleted the feat/2174-coming-sson-section-marketplace branch July 28, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a ‘Coming Soon’ section on the Marketplace ‘Browse’ page
3 participants