Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #2032 NPM broken badges, use absolute paths instead #2179

Merged
merged 2 commits into from
Jul 27, 2020
Merged

chore: #2032 NPM broken badges, use absolute paths instead #2179

merged 2 commits into from
Jul 27, 2020

Conversation

vuhuucuong
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2032

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2032

What is the new behavior?

  • Fix broken badges for npm packages

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from trankhacvy and willmcvay July 27, 2020 04:50
@github-actions github-actions bot added cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities web-components labels Jul 27, 2020
@vuhuucuong vuhuucuong changed the title chore: #2032 use absolute path instead chore: #2032 NPM broken badges, use absolute paths instead Jul 27, 2020
@auto-assign auto-assign bot requested review from nphivu414 and duong-se July 27, 2020 04:52
@vuhuucuong vuhuucuong force-pushed the chore/2032-npm-broken-badges branch from bc9fec1 to 7e4fe6c Compare July 27, 2020 05:42
@vuhuucuong vuhuucuong merged commit e5bc1b7 into master Jul 27, 2020
@vuhuucuong vuhuucuong deleted the chore/2032-npm-broken-badges branch July 27, 2020 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant066 ant066 ant066 approved these changes

@duong-se duong-se duong-se approved these changes

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

@nphivu414 nphivu414 Awaiting requested review from nphivu414

Assignees

@vuhuucuong vuhuucuong

Labels
cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities web-components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elements test badges are broken on NPM
3 participants
@vuhuucuong @duong-se @ant066