Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #2032 elements & cognito-auth & connect-session badges broken #2171

Merged
merged 3 commits into from
Jul 24, 2020

Conversation

vuhuucuong
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #2032

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2032

What is the new behavior?

  • Include badges when releasing to npm

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from duong-se and trankhacvy July 24, 2020 06:06
@github-actions github-actions bot added the elements Relates to Elements components and utilities label Jul 24, 2020
@auto-assign auto-assign bot requested a review from phmngocnghia July 24, 2020 06:08
@github-actions github-actions bot requested a review from ant066 July 24, 2020 06:49
@vuhuucuong vuhuucuong changed the title chore: #2032 elements badges broken chore: #2032 elements & cognito-auth & connect-session badges broken Jul 24, 2020
@github-actions github-actions bot added the cognito-auth Issue relates to Cognito Auth NPM package label Jul 24, 2020
@vuhuucuong vuhuucuong merged commit 75025e7 into master Jul 24, 2020
@vuhuucuong vuhuucuong deleted the chore/2032-elements-badges-broken-on-npm branch July 24, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elements test badges are broken on NPM
3 participants