Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1997 fix admin redirect modal on marketplace #2083

Merged
merged 1 commit into from
Jul 17, 2020
Merged

fix: #1997 fix admin redirect modal on marketplace #2083

merged 1 commit into from
Jul 17, 2020

Conversation

phmngocnghia
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1997

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested review from vuhuucuong and willmcvay July 17, 2020 05:54
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jul 17, 2020
duong-se
duong-se approved these changes Jul 17, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phmngocnghia phmngocnghia merged commit fab59c5 into master Jul 17, 2020
@phmngocnghia phmngocnghia deleted the fix/#1997-update-the-routing-and-app-title-for-the-new-standalone-apps branch July 17, 2020 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@phmngocnghia phmngocnghia

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the routing and app title for the new standalone apps
3 participants
@phmngocnghia @duong-se @vuhuucuong