Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2067 Developer Settings profile tab validation #2075

Merged
merged 2 commits into from
Jul 17, 2020

Conversation

vuhuucuong
Copy link
Contributor

@vuhuucuong vuhuucuong commented Jul 16, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #2067

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2067

What is the new behavior?

Add validation:

  • "Full Name" field: 256 characters
  • "Telephone" field: 20 number characters
  • "Job Title" field: 256 characters
  • "Company Name" field: 256 characters

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • Refactor to remove HOC & change validate method to yup
  • Also disable edit in Office Email field in Organisation tab

@duong-se duong-se merged commit e1ea44c into master Jul 17, 2020
@duong-se duong-se deleted the fix/2067-developer-profile-validation branch July 17, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Developer][Profile] Validation for fields on developer profile
3 participants