Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #1961 Update the filtering options on the ‘Detailed’ tab in ‘Analytics’ #2073

Merged
merged 1 commit into from
Jul 16, 2020
Merged

chore: #1961 Update the filtering options on the ‘Detailed’ tab in ‘Analytics’ #2073

merged 1 commit into from
Jul 16, 2020

Conversation

trankhacvy
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1961

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested review from vuhuucuong and willmcvay July 16, 2020 05:34
@github-actions github-actions bot closed this Jul 16, 2020
github-actions[bot]
github-actions bot reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request since the title does not match ^(?:(?:[WIP] ?)?(?:build|ci|chore|docs|feat|fix|perf|refactor|revert|style|test):(?:\ +?#\d+?\ +?)?.)|(?:[Snyk].) pattern. Please fix the title and re-open the pull request.

@trankhacvy trankhacvy changed the title #1961 Update the filtering options on the ‘Detailed’ tab in ‘Analytics’ chore: #1961 Update the filtering options on the ‘Detailed’ tab in ‘Analytics’ Jul 16, 2020
@trankhacvy trankhacvy reopened this Jul 16, 2020
duong-se
duong-se approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vuhuucuong
vuhuucuong approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 901e243 into master Jul 16, 2020
@duong-se duong-se deleted the chore/1961-Update-filtering-options-on-the-detailed-tab branch July 16, 2020 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@trankhacvy trankhacvy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the filtering options on the ‘Detailed’ tab in ‘Analytics’
3 participants
@trankhacvy @duong-se @vuhuucuong