Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #2011 Setting up Debit & integrate API in Dev Portal Setting billing tab #2071

Merged
merged 8 commits into from
Jul 16, 2020
Merged

feat: #2011 Setting up Debit & integrate API in Dev Portal Setting billing tab #2071

merged 8 commits into from
Jul 16, 2020

Conversation

vuhuucuong
Copy link
Contributor

@vuhuucuong vuhuucuong commented Jul 15, 2020 •
edited
Loading

Pull request checklist

Does this close any currently open issues?

fixes: #2011

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2011

What is the new behavior?

  • Integrate API with Billing tab
  • Add Direct Debit modal

image
image

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • Add validation for billing page form
  • Update config.json for developer-portal

@github-actions github-actions bot requested review from nphivu414 and duong-se July 15, 2020 14:26
@github-actions github-actions bot added the elements Relates to Elements components and utilities label Jul 15, 2020
@auto-assign auto-assign bot requested a review from ant066 July 15, 2020 14:26
@vuhuucuong vuhuucuong changed the title feat: #2011 setting up debit dev portal feat: #2011 Setting up Debit & integrate API in Dev Portal Setting billing tab Jul 15, 2020
@github-actions github-actions bot requested a review from willmcvay July 15, 2020 14:39
@vuhuucuong vuhuucuong force-pushed the feat/2011-setting-up-debit-dev-portal branch from 272370f to eb5e2c1 Compare July 15, 2020 16:21
duong-se
duong-se approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuhuucuong vuhuucuong force-pushed the feat/2011-setting-up-debit-dev-portal branch from d26455d to af090ea Compare July 16, 2020 06:47
@github-actions github-actions bot requested a review from duong-se July 16, 2020 06:47
@vuhuucuong vuhuucuong changed the title feat: #2011 Setting up Debit & integrate API in Dev Portal Setting billing tab [WIP] feat: #2011 Setting up Debit & integrate API in Dev Portal Setting billing tab Jul 16, 2020
@vuhuucuong vuhuucuong force-pushed the feat/2011-setting-up-debit-dev-portal branch 2 times, most recently from e891650 to d26455d Compare July 16, 2020 07:01
@vuhuucuong vuhuucuong changed the title [WIP] feat: #2011 Setting up Debit & integrate API in Dev Portal Setting billing tab feat: #2011 Setting up Debit & integrate API in Dev Portal Setting billing tab Jul 16, 2020
@vuhuucuong vuhuucuong force-pushed the feat/2011-setting-up-debit-dev-portal branch from d26455d to d6a8a2c Compare July 16, 2020 07:03
@github-actions github-actions bot requested a review from trankhacvy July 16, 2020 07:04
@github-actions github-actions bot requested a review from phmngocnghia July 16, 2020 07:16
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jul 16, 2020
@vuhuucuong vuhuucuong merged commit d3df4f4 into master Jul 16, 2020
@vuhuucuong vuhuucuong deleted the feat/2011-setting-up-debit-dev-portal branch July 16, 2020 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant066 ant066 ant066 approved these changes

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@willmcvay willmcvay Awaiting requested review from willmcvay

@duong-se duong-se Awaiting requested review from duong-se

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

Assignees

@vuhuucuong vuhuucuong

Labels
elements Relates to Elements components and utilities marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Populate and create the action for setting up a Direct Debit
3 participants
@vuhuucuong @duong-se @ant066