Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1920 element next jest test #2069

Merged
merged 3 commits into from
Jul 16, 2020

Conversation

duong-se
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1920

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1920

What is the new behavior?

  • Jest test config for next element

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot requested review from ant066 and phmngocnghia July 16, 2020 04:28
@duong-se duong-se force-pushed the feat/1920-element-next-jest-test-config branch from 78164f9 to 4e08604 Compare July 16, 2020 06:53
@duong-se duong-se force-pushed the feat/1920-element-next-jest-test-config branch from 4e08604 to 5792d9c Compare July 16, 2020 07:28
@github-actions github-actions bot requested a review from vuhuucuong July 16, 2020 07:29
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 8a103b6 into master Jul 16, 2020
@duong-se duong-se deleted the feat/1920-element-next-jest-test-config branch July 16, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create build scripts and project setup for Elements v2
3 participants