Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #2012 update ‘developer management’ on admin portal #2062

Merged
merged 4 commits into from
Jul 16, 2020
Merged

feat: #2012 update ‘developer management’ on admin portal #2062

merged 4 commits into from
Jul 16, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented Jul 14, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #2012

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #2012

What is the new behavior?

  • Update ‘developer management’ on the admin portal

Screen Shot 2020-07-14 at 5 36 07 PM

Screen Shot 2020-07-14 at 5 36 24 PM

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested review from duong-se and trankhacvy July 14, 2020 11:32
@ant066 ant066 force-pushed the feat/2012-update-dev-manage-admin-portal branch from 06f5269 to 3a366f8 Compare July 14, 2020 11:35
@github-actions github-actions bot requested review from nphivu414 and willmcvay July 14, 2020 11:35
@github-actions github-actions bot added the elements Relates to Elements components and utilities label Jul 14, 2020
@ant066 ant066 force-pushed the feat/2012-update-dev-manage-admin-portal branch from 28b1469 to b698207 Compare July 16, 2020 04:49
duong-se
duong-se approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ant066 ant066 force-pushed the feat/2012-update-dev-manage-admin-portal branch from e936e7d to 10fa55c Compare July 16, 2020 07:33
@ant066 ant066 force-pushed the feat/2012-update-dev-manage-admin-portal branch from 10fa55c to e7ad3c1 Compare July 16, 2020 08:01
@github-actions github-actions bot requested a review from phmngocnghia July 16, 2020 08:01
@github-actions github-actions bot requested a review from duong-se July 16, 2020 08:33
@duong-se duong-se merged commit 1e9975b into master Jul 16, 2020
@duong-se duong-se deleted the feat/2012-update-dev-manage-admin-portal branch July 16, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@willmcvay willmcvay Awaiting requested review from willmcvay

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

Assignees

@ant066 ant066

Labels
elements Relates to Elements components and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update ‘Developer Management’ on Admin Portal
3 participants
@ant066 @trankhacvy @duong-se