Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #1918 remove unused code from marketplace login page #2008

Merged
merged 2 commits into from
Jul 9, 2020
Merged

chore: #1918 remove unused code from marketplace login page #2008

merged 2 commits into from
Jul 9, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented Jul 8, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #1918

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1918

What is the new behavior?

  • remove unused code from the marketplace login page

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested review from nphivu414 and willmcvay July 8, 2020 10:53
@github-actions github-actions bot requested review from duong-se and vuhuucuong July 8, 2020 10:53
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jul 8, 2020
duong-se
duong-se approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ant066 ant066 merged commit 2c5a537 into master Jul 9, 2020
@ant066 ant066 deleted the chore/1918-remove-unuse-code-from-marketplace branch July 9, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@duong-se duong-se duong-se approved these changes

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@willmcvay willmcvay Awaiting requested review from willmcvay

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@ant066 ant066

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Purge unused code from marketplace
3 participants
@ant066 @duong-se @phmngocnghia