Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: #1875 Update the helper notification message when a developer has no registered apps #1883

Merged
merged 1 commit into from
Jun 30, 2020
Merged

chore: #1875 Update the helper notification message when a developer has no registered apps #1883

merged 1 commit into from
Jun 30, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented Jun 30, 2020 •
edited
Loading

Pull request checklist

Does this close any currently open issues?

fixes: #1875

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1875

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested review from trankhacvy and willmcvay June 30, 2020 07:14
@github-actions github-actions bot added cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities labels Jun 30, 2020
@ant066 ant066 force-pushed the feat/1875-update-developer-helper-tet branch from bce2bd8 to 128d04e Compare June 30, 2020 07:57
@github-actions github-actions bot requested review from duong-se and vuhuucuong June 30, 2020 07:58
@ant066 ant066 force-pushed the feat/1875-update-developer-helper-tet branch from 4173f34 to 78875a1 Compare June 30, 2020 07:59
@github-actions github-actions bot requested a review from nphivu414 June 30, 2020 08:00
@ant066 ant066 merged commit 7ef6d33 into master Jun 30, 2020
@ant066 ant066 deleted the feat/1875-update-developer-helper-tet branch June 30, 2020 08:26
duong-se
duong-se reviewed Jun 30, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se left review comments

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@nphivu414 nphivu414 nphivu414 approved these changes

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@ant066 ant066

Labels
cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the helper notification message when a developer has no registered apps
4 participants
@ant066 @nphivu414 @duong-se @vuhuucuong