-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1848 filter app lists when using the marketplace in Developer Edition #1851
feat: #1848 filter app lists when using the marketplace in Developer Edition #1851
Conversation
3a88ff0
to
122ed8a
Compare
@@ -19,6 +19,7 @@ export const mockLoginSession: LoginSession = { | |||
userCode: 'SOME_USER_CODE', | |||
isAdmin: false, | |||
userTel: '123', | |||
groups: ['AgencyCloudDeveloperEdition'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should use const COGNITO_GROUP_DEVELOPER_EDITION
@@ -66,6 +66,7 @@ const appState: ReduxState = { | |||
adminId: null, | |||
userCode: 'testUserCode', | |||
userTel: '123', | |||
groups: ['AgencyCloudDeveloperEdition'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
* AgencyCloudDeveloperEdition group, if not just return null | ||
* refer to this ticket https://github.com/reapit/foundations/issues/1848 | ||
*/ | ||
export const selectDeveloperId = (state: ReduxState) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Naming seems ambiguous to me even with comment on the func. Imagine we will need to selectDeveloperId in the future without this logic. Something like selectDeveloperIdIfBelong(group)
would be better. Just a suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@phmngocnghia's comment makes sense, and should add return value type too.
It may cause confusion when we splitting to Client/Dev portal next week
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selectDeveloperEditionId
as a name maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with the comments already made, others look good though!
* AgencyCloudDeveloperEdition group, if not just return null | ||
* refer to this ticket https://github.com/reapit/foundations/issues/1848 | ||
*/ | ||
export const selectDeveloperId = (state: ReduxState) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
selectDeveloperEditionId
as a name maybe?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Pull request checklist
Does this close any currently open issues?
fixes: #1848
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn lint
) has passed locally and any fixes were made for failuresyarn test
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #
What is the new behavior?
Does this introduce a breaking change?
Other information