Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: #1325 Refactor toast messages using react-redux hooks #1803

Merged
merged 1 commit into from
Jun 22, 2020
Merged

refactor: #1325 Refactor toast messages using react-redux hooks #1803

merged 1 commit into from
Jun 22, 2020

Conversation

nphivu414
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1325

What is the new behavior?

  • The behavior will stay the same

Does this introduce a breaking change?

  • Yes
  • No

Other information

@auto-assign auto-assign bot requested review from ant066 and willmcvay June 22, 2020 04:00
@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jun 22, 2020
duong-se
duong-se approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ant066
ant066 approved these changes Jun 22, 2020
View reviewed changes
Copy link
Contributor

@ant066 ant066 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nphivu414 nphivu414 merged commit d777498 into master Jun 22, 2020
@nphivu414 nphivu414 deleted the refactor/1325-toast-message-mapstatetoprops-to-useselector branch June 22, 2020 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant066 ant066 ant066 approved these changes

@duong-se duong-se duong-se approved these changes

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@nphivu414 nphivu414

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nphivu414 @duong-se @ant066