Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: hide web-component config button #1568

Merged
merged 1 commit into from
Jun 5, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented Jun 5, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): just hide the web-component config button because the API not ready

What is the current behavior?

The web-component config button still visible but the API not ready, it will be a bug if the user configures it.

Issue Number: #

What is the new behavior?

Hide the web-component config button in Client Portal: App Details Page

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the marketplace Relates to the Marketplace label Jun 5, 2020
@auto-assign auto-assign bot requested a review from vuhuucuong June 5, 2020 02:52
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ant066 ant066 merged commit bf194b3 into master Jun 5, 2020
@ant066 ant066 deleted the chore/1033-hide-web-component-config-btn branch June 5, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants