Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1419 service worker issue in production #1434

Merged
merged 1 commit into from
May 31, 2020

Conversation

phmngocnghia
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1419

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  • create a branch, checkout to 9e83443 before sw got remove, to get the same env as people got service worker error
    make sure your service worker is working by:
  • put a button the page
  • install event to call runtime.update function:

import * as runtime from 'offline-plugin/runtime'
runtime.update()

  • build and start prod
  • change some parts of the code and rebuild
  • press button -> toast show up
  • service worker is installed on dev tool -: Application tab -> Service worker

Issue Number: #1419

What is the new behavior?

  • Cherry pick commit in this branch to your created branch
  • Rebuild the app
  • Press button on the route created ^ -> no toast show up
  • No service worker installed on Application tab -> Service worker (uninstalled)

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 93ab69a into master May 31, 2020
@duong-se duong-se deleted the fix-1419-service-worker-issue-in-production branch May 31, 2020 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix service worker issue in production
3 participants