Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1371 filtering-mobile-and-ui-issues-on-browse-apps #1433

Merged
merged 1 commit into from
Jun 2, 2020
Merged

fix: #1371 filtering-mobile-and-ui-issues-on-browse-apps #1433

merged 1 commit into from
Jun 2, 2020

Conversation

phmngocnghia
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1371

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

image

Issue Number: #1371

What is the new behavior?

image

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the marketplace Relates to the Marketplace label May 29, 2020
duong-se
duong-se approved these changes May 31, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phmngocnghia phmngocnghia merged commit b0b3db9 into master Jun 2, 2020
@phmngocnghia phmngocnghia deleted the fix-1371-filtering-mobile-and-ui-issues-on-browse-apps branch June 2, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@willmcvay willmcvay willmcvay approved these changes

@ant066 ant066 Awaiting requested review from ant066

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

Assignees

@phmngocnghia phmngocnghia

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering mobile and UI issues on 'Browse Apps'
4 participants
@phmngocnghia @willmcvay @duong-se @vuhuucuong