Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1390 sourcemaps not loaded in dev and prod #1402

Merged
merged 1 commit into from
May 28, 2020

Conversation

nphivu414
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1390

What is the new behavior?

  • Will not throw any error log about missing sourcemaps in dev and prod

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nphivu414 nphivu414 merged commit 14bee06 into master May 28, 2020
@nphivu414 nphivu414 deleted the fix/1390-source-maps-not-loaded-in-dev-and-prod branch May 28, 2020 11:17
@nphivu414 nphivu414 linked an issue May 28, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The source maps for marketplace do not load in dev or production
3 participants