feat: #1369 The Web Components Config API should store config by appId #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
ant066,
nphivu414,
duong-se,
trankhacvy,
vuhuucuong and
willmcvay
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
phmngocnghia
changed the title
phmngocnghia
changed the title
vuhuucuong
suggested changes
May 28, 2020
phmngocnghia
changed the title
duong-se
added
the
do not merge
duong-se
reviewed
Jun 1, 2020
packages/web-components-config-server/src/routes/web-components-config/web-components-config.ts
Outdated
Show resolved
Hide resolved
duong-se
reviewed
Jun 1, 2020
| export const webComponentsConfigPostHandler = async (req: AppRequest, res: AppResponse) => { | ||
| try { | ||
| const params = { | ||
| data: { ...req.body, customerId: req.params.customerId, appId: req.params.appId }, |
There was a problem hiding this comment.
shoud we use opt chain to check null or undefined ?
There was a problem hiding this comment.
It's params from express route matching. Pretty sure about value of these field are always something not null
phmngocnghia
force-pushed
the
feat-#1039-the-web-components-config-api-should-store-config-by-app-id
branch
from
3f66d73 to
7735943
Compare
phmngocnghia
removed
the
do not merge
phmngocnghia
changed the title
vuhuucuong
approved these changes
Jun 19, 2020
Comment on lines
+42
to
+61
| export const patchConfig = async ({ traceId, data }: UpdateParams): Promise<WebComponentConfig> => { | ||
| try { | ||
| logger.info('Updating config...', { traceId, data }) | ||
| const { customerId, ...rest } = data | ||
| const oldItem = await getConfigByClientId({ traceId, data: { customerId } }) | ||
| logger.info('Patching config...', { traceId, data }) | ||
| const { customerId, appId, ...rest } = data | ||
| const oldItem = await getConfigByClientId({ traceId, data: { customerId, appId } }) | ||
| const itemToUpdate = generateSchemaItem({ ...oldItem, ...rest }) | ||
| const result = await dynamoDBMapper.update(itemToUpdate) | ||
| logger.info('Patch config successfully', { traceId, result }) | ||
| return result | ||
| } catch (error) { | ||
| await logger.error('Patch config failed', { traceId, error: stringifyError(error) }) | ||
| throw error | ||
| } | ||
| } | ||
|
|
||
| export const putConfig = async ({ traceId, data }): Promise<WebComponentConfig> => { | ||
| try { | ||
| logger.info('Updating config...', { traceId, data }) | ||
| const itemToUpdate = generateSchemaItem(data) | ||
| const result = await dynamoDBMapper.put(itemToUpdate) |
There was a problem hiding this comment.
just wonder why we need both PUT, and PATCH to update ?
There was a problem hiding this comment.
@phmngocnghia please fix to the next PR
duong-se
deleted the
feat-#1039-the-web-components-config-api-should-store-config-by-app-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #1369
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
old route:
webComponentsConfig.get('/:customerId', webComponentsConfigGetByIdHandler) webComponentsConfig.put('/', webComponentsConfigPutHandler) webComponentsConfig.patch('/:customerId', webComponentsConfigPatchHandler) webComponentsConfig.delete('/:customerId', webComponentsConfigDeleteHandler)Issue Number: #1369
What is the new behavior?
Add
appIdto all CRUD routeswebComponentsConfig.post('/:customerId/:appId', webComponentsConfigPostHandler) webComponentsConfig.get('/:customerId/:appId', webComponentsConfigGetByIdHandler) webComponentsConfig.delete('/:customerId/:appId', webComponentsConfigDeleteHandler) webComponentsConfig.patch('/:customerId/:appId', webComponentsConfigPatchHandler) webComponentsConfig.put('/:customerId/:appId', webComponentsConfigPutHandler)Does this introduce a breaking change?
Other information
Will need to add global secondary index key to
appIdfield: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/getting-started-step-6.html