Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1392 Hide loader after finishing fetching data in analytics page #1398

Merged
merged 1 commit into from
May 28, 2020
Merged

fix: #1392 Hide loader after finishing fetching data in analytics page #1398

merged 1 commit into from
May 28, 2020

Conversation

nphivu414
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes:

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1392

What is the new behavior?

  • Hide loader after successfully fetching data in analytics page

Does this introduce a breaking change?

  • Yes
  • No

Other information

Before:
Screenshot_2
After:
Screenshot_1

@github-actions github-actions bot added the marketplace Relates to the Marketplace label May 28, 2020
@nphivu414 nphivu414 linked an issue May 28, 2020 that may be closed by this pull request
New users see endless loading spinners on the Cost Explorer page #1392
Closed
vuhuucuong
vuhuucuong approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

duong-se
duong-se approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nphivu414 nphivu414 merged commit 1cb0e42 into master May 28, 2020
@nphivu414 nphivu414 deleted the fix/1392-endless-loading-spinner-on-cost-explorer-page branch May 28, 2020 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@ant066 ant066 Awaiting requested review from ant066

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@nphivu414 nphivu414

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New users see endless loading spinners on the Cost Explorer page
3 participants
@nphivu414 @duong-se @vuhuucuong