Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove offline plugin #1387

Merged
merged 4 commits into from
May 29, 2020
Merged

chore: remove offline plugin #1387

merged 4 commits into from
May 29, 2020

Conversation

phmngocnghia
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added aml-checklist Relates to Anti-money laundering app elements Relates to Elements components and utilities geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App smb-onboarder Relates to Small Medium Business onboarding app labels May 28, 2020
vuhuucuong
vuhuucuong approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

duong-se
duong-se suggested changes May 28, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls remove it from package.json also

@github-actions github-actions bot requested review from duong-se and vuhuucuong May 28, 2020 10:04
duong-se
duong-se approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 78db4a6 into master May 29, 2020
@duong-se duong-se deleted the chore-remove-offline-plugin branch May 29, 2020 03:05
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duong-se duong-se duong-se approved these changes

@ant066 ant066 Awaiting requested review from ant066

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@phmngocnghia phmngocnghia

Labels
aml-checklist Relates to Anti-money laundering app elements Relates to Elements components and utilities geo-diary Relates to GEO Diary app lifetime-legal Relates to Lifetime Legal App smb-onboarder Relates to Small Medium Business onboarding app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phmngocnghia @duong-se @vuhuucuong