-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: #1126 Route to the new standalone app page #1368
Merged
nphivu414
merged 18 commits into
master
from
feat/1126-route-to-the-new-standalone--app-page
Jun 2, 2020
Merged
feat: #1126 Route to the new standalone app page #1368
nphivu414
merged 18 commits into
master
from
feat/1126-route-to-the-new-standalone--app-page
Jun 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eat/1126-route-to-the-new-standalone--app-page
github-actions
bot
requested review from
ant066,
phmngocnghia,
duong-se,
trankhacvy,
vuhuucuong and
willmcvay
May 27, 2020 11:10
duong-se
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vuhuucuong
approved these changes
May 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
nphivu414
added
the
do not merge
Branch should not be merged into main workflow in current state
label
May 29, 2020
duong-se
removed
the
do not merge
Branch should not be merged into main workflow in current state
label
Jun 2, 2020
…eat/1126-route-to-the-new-standalone--app-page
…ps://github.com/reapit/foundations into feat/1126-route-to-the-new-standalone--app-page
…eat/1126-route-to-the-new-standalone--app-page
…eat/1126-route-to-the-new-standalone--app-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
aml-checklist
Relates to Anti-money laundering app
marketplace
Relates to the Marketplace
web-components
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #
Please check if your PR fulfills the following requirements:
yarn build
) was run locally and any changes were pushedyarn lint
) has passed locally and any fixes were made for failuresyarn test
) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #1126
What is the new behavior?
Does this introduce a breaking change?
Other information
Please do not merge this ticket. I'll merge this ticket myself after tickets #1206 #1225 are completed and passed QA
Before:
After: