fix: #1210 #1206 - update render 'category', 'Desktop Integration Types', 'Private App' #1366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phmngocnghia
changed the title
github-actions
bot
requested review from
ant066,
nphivu414,
duong-se,
trankhacvy,
vuhuucuong and
willmcvay
phmngocnghia
force-pushed
the
fix-1210-1206-update-render-private-app
branch
from
16ad7fd to
1a229f0
Compare
nphivu414
suggested changes
May 27, 2020
packages/marketplace/src/utils/__tests__/get-desktop-integration-types.ts
Outdated
Show resolved
Hide resolved
vuhuucuong
approved these changes
May 27, 2020
nphivu414
approved these changes
May 27, 2020
phmngocnghia
force-pushed
the
fix-1210-1206-update-render-private-app
branch
from
a7698e5 to
ac4a186
Compare
ant066
reviewed
May 29, 2020
| @@ -114,7 +114,7 @@ const AppContent: React.FC<AppContentProps> = ({ appDetailData }) => { | |||
| return ( | |||
| <div className={clientAppDetailStyles.appContentContainer}> | |||
| {isVisibleUninstallModal && ( | |||
| <Modal visible={isVisibleUninstallModal}> | |||
| <Modal renderChildren className="nghia-test-test" visible={isVisibleUninstallModal}> | |||
There was a problem hiding this comment.
should change the className
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #1210 #1206
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #1210 #1206
What is the new behavior?
Render
Nonefor empty desktop integration typeRemap value to desktop integration type
Remap value of
Private Appfieldhttp://localhost:8080/developer/apps/5c0ce6b1-0573-4594-9606-adb55671d8b8
Does this introduce a breaking change?
Other information