Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1033 update config web component button #1365

Merged
merged 1 commit into from
May 27, 2020
Merged

fix: #1033 update config web component button #1365

merged 1 commit into from
May 27, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented May 27, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1033

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the marketplace Relates to the Marketplace label May 27, 2020
duong-se
duong-se approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ant066 ant066 merged commit bcbabc8 into master May 27, 2020
@ant066 ant066 deleted the feat/1033-config-webcomponent branch May 27, 2020 06:58
@snyk-bot snyk-bot mentioned this pull request Jan 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@duong-se duong-se duong-se approved these changes

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@willmcvay willmcvay Awaiting requested review from willmcvay

Assignees

@ant066 ant066

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ant066 @duong-se @vuhuucuong