Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: #1326 Refactor client apps page using new react-redux hooks #1334

Merged
merged 6 commits into from
May 26, 2020

Conversation

ant066
Copy link
Contributor

@ant066 ant066 commented May 25, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • [] Bugfix
  • [] Feature
  • [] Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • [] Build related changes
  • [] Documentation content changes
  • [] Other (please describe):

What is the current behavior?

Issue Number: #1326

What is the new behavior?

Does this introduce a breaking change?

  • [] Yes
  • No

Other information

@github-actions github-actions bot added the marketplace Relates to the Marketplace label May 25, 2020
@ant066 ant066 requested a review from nphivu414 May 26, 2020 04:18
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with @tanphamhaiduong 's comments

@github-actions github-actions bot requested review from duong-se and willmcvay May 26, 2020 07:38
@ant066 ant066 merged commit 5ff9bd8 into master May 26, 2020
@ant066 ant066 deleted the refactor/1326-client-page branch May 26, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants