Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #1222 create infra for appointment planner api #1317

Merged
merged 3 commits into from
May 26, 2020

Conversation

trankhacvy
Copy link
Contributor

Pull request checklist

Does this close any currently open issues?

fixes: #1222

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing this pull request since the title does not match ^(?:build|ci|chore|docs|feat|fix|perf|refactor|revert|style|test):(?:\ +?#\d+?\ +?)?.* pattern. Please fix the title and re-open the pull request.

@trankhacvy trankhacvy changed the title [WIP] feat: #1222 create infra for appointment planner api feat: #1222 create infra for appointment planner api [WIP] May 22, 2020
@trankhacvy trankhacvy reopened this May 22, 2020
@trankhacvy trankhacvy changed the title feat: #1222 create infra for appointment planner api [WIP] feat: #1222 create infra for appointment planner api May 25, 2020
@trankhacvy trankhacvy force-pushed the feat/1222-appointment-planner-api-infra branch from e0b79b9 to 0e2a5a0 Compare May 26, 2020 01:51
@github-actions github-actions bot requested a review from vuhuucuong May 26, 2020 01:52
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trankhacvy trankhacvy merged commit 3c687d1 into master May 26, 2020
@trankhacvy trankhacvy deleted the feat/1222-appointment-planner-api-infra branch May 26, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create infra for Appointment Planner API
3 participants