feat: #1033 configure my web component installations in the Marketplace #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-assign
bot
requested review from
nphivu414,
phmngocnghia,
duong-se,
trankhacvy,
vuhuucuong and
willmcvay
added 2 commits
May 22, 2020 08:27
github-actions
bot
added
elements
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ant066
changed the title
|
@ant066 FYI, the server has been deployed at https://vwvdddbw9k.execute-api.eu-west-2.amazonaws.com/dev |
duong-se
reviewed
May 25, 2020
duong-se
reviewed
May 25, 2020
duong-se
reviewed
May 25, 2020
packages/marketplace/src/components/ui/web-component-config-modal/config-modal.tsx
Outdated
Show resolved
Hide resolved
duong-se
reviewed
May 25, 2020
packages/marketplace/src/components/ui/web-component-config-modal/config-modal.tsx
Outdated
Show resolved
Hide resolved
duong-se
reviewed
May 25, 2020
packages/marketplace/src/components/ui/web-component-config-modal/config-modal.tsx
Outdated
Show resolved
Hide resolved
duong-se
reviewed
May 25, 2020
duong-se
reviewed
May 25, 2020
duong-se
approved these changes
May 26, 2020
willmcvay
requested changes
May 26, 2020
packages/marketplace/src/components/pages/client-app-detail/__test__/aside.test.tsx
Outdated
Show resolved
Hide resolved
...arketplace/src/components/ui/web-component-config-modal/__test__/config-modal-inner.test.tsx
Outdated
Show resolved
Hide resolved
...arketplace/src/components/ui/web-component-config-modal/__test__/config-modal-inner.test.tsx
Outdated
Show resolved
Hide resolved
packages/marketplace/src/components/ui/web-component-config-modal/config-modal-inner.tsx
Outdated
Show resolved
Hide resolved
packages/marketplace/src/components/ui/web-component-config-modal/config-modal-inner.tsx
Outdated
Show resolved
Hide resolved
packages/marketplace/src/components/ui/web-component-config-modal/config-modal-inner.tsx
Outdated
Show resolved
Hide resolved
Hi @willmcvay, I updated. So can you review it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Does this close any currently open issues?
fixes: #1033
Please check if your PR fulfills the following requirements:
yarn build) was run locally and any changes were pushedyarn lint) has passed locally and any fixes were made for failuresyarn test) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: #1033
What is the new behavior?
Does this introduce a breaking change?
Other information
I use dummy data for API response while waiting for API ready