Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #1289 web-components-config-server deploy #1308

Merged
merged 1 commit into from
May 22, 2020

Conversation

vuhuucuong
Copy link
Contributor

@vuhuucuong vuhuucuong commented May 21, 2020

Pull request checklist

Does this close any currently open issues?

fixes: #1289

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (yarn build) was run locally and any changes were pushed
  • Lint (yarn lint) has passed locally and any fixes were made for failures
  • Test (yarn test) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #1289

What is the new behavior?

  • Deploy web-components-config-server to AWS

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vuhuucuong vuhuucuong merged commit cee6b61 into master May 22, 2020
@vuhuucuong vuhuucuong deleted the chore/1289-web-components-config-server-deploy branch May 22, 2020 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Components Config Server should be deployed to AWS using serverless
3 participants