Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1225 ui for mobile client side app #1271

Merged
merged 6 commits into from
May 19, 2020
Merged

fix: #1225 ui for mobile client side app #1271

merged 6 commits into from
May 19, 2020

Conversation

phmngocnghia
Copy link
Contributor

fixes #1225

@github-actions github-actions bot added the marketplace Relates to the Marketplace label May 18, 2020
willmcvay
willmcvay approved these changes May 18, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With @tanphamhaiduong 's fixes, looks good to me 👍

@phmngocnghia phmngocnghia force-pushed the fix-#1225-ui-for-mobile-client-side-app branch from 11832e1 to f843d91 Compare May 19, 2020 04:35
@github-actions github-actions bot requested review from duong-se and willmcvay May 19, 2020 04:36
duong-se
duong-se approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@duong-se duong-se left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phmngocnghia phmngocnghia force-pushed the fix-#1225-ui-for-mobile-client-side-app branch from f843d91 to 605cec1 Compare May 19, 2020 07:13
@github-actions github-actions bot requested a review from duong-se May 19, 2020 07:13
@phmngocnghia phmngocnghia force-pushed the fix-#1225-ui-for-mobile-client-side-app branch from 605cec1 to ad23c79 Compare May 19, 2020 07:47
@phmngocnghia phmngocnghia force-pushed the fix-#1225-ui-for-mobile-client-side-app branch from ad23c79 to 20fc0b8 Compare May 19, 2020 08:19
@phmngocnghia phmngocnghia merged commit 35b0ced into master May 19, 2020
@phmngocnghia phmngocnghia deleted the fix-#1225-ui-for-mobile-client-side-app branch May 19, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ant066 ant066 Awaiting requested review from ant066

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

@willmcvay willmcvay Awaiting requested review from willmcvay

@duong-se duong-se Awaiting requested review from duong-se

Assignees

@phmngocnghia phmngocnghia

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI for mobile client-side app
3 participants
@phmngocnghia @willmcvay @duong-se