Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1145 integrate api for billing bar chart #1168

Merged
merged 1 commit into from
May 7, 2020
Merged

feat: #1145 integrate api for billing bar chart #1168

merged 1 commit into from
May 7, 2020

Conversation

duong-se
Copy link
Contributor

@duong-se duong-se commented May 7, 2020

feat: #1145

Changes

  • Integrate api for billing bar chart
  • Write test
  • Refactor some places

@github-actions github-actions bot added the marketplace Relates to the Marketplace label May 7, 2020
@duong-se duong-se force-pushed the feat/1145-billing-bar-chart branch 4 times, most recently from 7bddda2 to b595d2b Compare May 7, 2020 10:44
@duong-se
feat: integrate api for billing bar chart
93453c9 
Changes
- Integrate api for billing bar chart
- Write test
- Refactor some places
@duong-se duong-se force-pushed the feat/1145-billing-bar-chart branch from b595d2b to 93453c9 Compare May 7, 2020 11:38
willmcvay
willmcvay approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

vuhuucuong
vuhuucuong approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@vuhuucuong vuhuucuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duong-se duong-se merged commit 533632f into master May 7, 2020
@duong-se duong-se deleted the feat/1145-billing-bar-chart branch May 7, 2020 15:51
@duong-se duong-se linked an issue May 7, 2020 that may be closed by this pull request
Bar Chart Update (Billing/Analytics) #1145
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vuhuucuong vuhuucuong vuhuucuong approved these changes

@willmcvay willmcvay willmcvay approved these changes

@ant066 ant066 Awaiting requested review from ant066

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@phmngocnghia phmngocnghia Awaiting requested review from phmngocnghia

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

Assignees

@duong-se duong-se

Labels
marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bar Chart Update (Billing/Analytics)
3 participants
@duong-se @willmcvay @vuhuucuong