Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #1123 render text editor instead of textarea for submit app #1151

Merged
merged 1 commit into from
May 5, 2020
Merged

feat: #1123 render text editor instead of textarea for submit app #1151

merged 1 commit into from
May 5, 2020

Conversation

duong-se
Copy link
Contributor

@duong-se duong-se commented May 5, 2020

feat: #1123
Changes

  • Render text editor instead of TextArea for submitting an app
  • Fix TextAreaEditor for binding data to field

@github-actions github-actions bot added cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities marketplace Relates to the Marketplace labels May 5, 2020
@duong-se duong-se force-pushed the feat/1123-render-text-edit-instead-of-text-area branch from f4f3e5d to da13211 Compare May 5, 2020 09:50
@github-actions github-actions bot requested a review from willmcvay May 5, 2020 09:51
@duong-se duong-se force-pushed the feat/1123-render-text-edit-instead-of-text-area branch from da13211 to 4c717cc Compare May 5, 2020 13:30
willmcvay
willmcvay approved these changes May 5, 2020
View reviewed changes
Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@duong-se duong-se merged commit e503f3a into master May 5, 2020
@duong-se duong-se deleted the feat/1123-render-text-edit-instead-of-text-area branch May 5, 2020 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phmngocnghia phmngocnghia phmngocnghia approved these changes

@willmcvay willmcvay willmcvay approved these changes

@ant066 ant066 Awaiting requested review from ant066

@nphivu414 nphivu414 Awaiting requested review from nphivu414

@trankhacvy trankhacvy Awaiting requested review from trankhacvy

@vuhuucuong vuhuucuong Awaiting requested review from vuhuucuong

Assignees

@duong-se duong-se

Labels
cognito-auth Issue relates to Cognito Auth NPM package elements Relates to Elements components and utilities marketplace Relates to the Marketplace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duong-se @willmcvay @phmngocnghia