Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deployment resolution #11492

Merged
merged 11 commits into from
Nov 15, 2024
Merged

fix: deployment resolution #11492

merged 11 commits into from
Nov 15, 2024

Conversation

bashleigh
Copy link
Contributor

Pull request checklist

Detail as per issue below (required):

fixes: #

Copy link

codacy-production bot commented Nov 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 56a0d991 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (56a0d99) Report Missing Report Missing Report Missing
Head commit (cb451c6) 19450 16362 84.12%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#11492) 8 8 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Contributor

@willmcvay willmcvay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bashleigh bashleigh merged commit 08d1d81 into master Nov 15, 2024
11 checks passed
@bashleigh bashleigh deleted the fix/deployment-resolution branch November 15, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants