Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #10611 pkce #11018

Merged
merged 25 commits into from
Apr 17, 2024
Merged

feat: #10611 pkce #11018

merged 25 commits into from
Apr 17, 2024

Conversation

bashleigh
Copy link
Contributor

Pull request checklist

Detail as per issue below (required):

fixes: #10611

bashleigh and others added 4 commits April 12, 2024 16:02
@bashleigh
fix: mock crypto on windows
0966fab
@github-actions @willmcvay @bashleigh
Update ts definitions (#10999)
437186b 
Co-authored-by: willmcvay <[email protected]>
Co-authored-by: Will McVay <[email protected]>
@willmcvay @bashleigh
feat: #11017 admin portal elements beta (#11019)
af9dfab 
* feat: #11017 admin portal elements betal

* feat: #11017 admin portal elements betal

* feat: #11017 admin portal migrate beta
@bashleigh
feat: added test for making sure fetch is called with post request wi…
e5cc768 
…th body
Base automatically changed from refactor/#10612-convert-connection-session-token-requests-to-post-body to master April 15, 2024 11:41
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

joshbalfour
joshbalfour approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@joshbalfour joshbalfour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bashleigh bashleigh merged commit dee97a3 into master Apr 17, 2024
13 checks passed
@bashleigh bashleigh deleted the feat/#10611-pkce branch April 17, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plittlewood-rpt plittlewood-rpt plittlewood-rpt left review comments

@willmcvay willmcvay willmcvay left review comments

@joshbalfour joshbalfour joshbalfour approved these changes

Assignees
No one assigned
Labels
admin-portal app-builder app-market connect-session dependencies foundations-ts-definitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement PKCE in connect-session
4 participants
@bashleigh @joshbalfour @willmcvay @plittlewood-rpt