Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor fetching apps to provide appName to installations #8059

Closed
willmcvay opened this issue Nov 4, 2022 · 0 comments · Fixed by #8395
Closed

Refactor fetching apps to provide appName to installations #8059

willmcvay opened this issue Nov 4, 2022 · 0 comments · Fixed by #8395
Assignees
@willmcvay
Labels
admin-portal developer-portal front-end Relates to front end issues marketplace Relates to the Marketplace task

Comments

@willmcvay
Copy link
Contributor

willmcvay commented Nov 4, 2022 •
edited
Loading

Background context or User story:

Previously the InstallationModel only supplied appId, hence there is a number of places in the codebase, we fetch apps by id to populate the appName when rendering lists of installations. Certainly this is the case in the Admin Portal, App Market and Developer portal installation tables, possibly in other places, needs investigation. As the appName is now supplied, we should refactor these places for efficiency
@willmcvay willmcvay added front-end Relates to front end issues marketplace Relates to the Marketplace admin-portal developer-portal task labels Nov 4, 2022
@willmcvay willmcvay self-assigned this Jan 24, 2023
willmcvay added a commit that referenced this issue Jan 24, 2023
@willmcvay
feat: #8392 #8059 improves installation handling
aa80a10
@willmcvay willmcvay mentioned this issue Jan 24, 2023
Merged
willmcvay added a commit that referenced this issue Jan 24, 2023
@willmcvay
feat: #8392 #8059 improves installations handling (#8395)
56b6c06 
* feat: #8392 #8059 improves installation handling

* fix: release dev fix
@snyk-bot snyk-bot mentioned this issue Feb 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmcvay willmcvay

Labels
admin-portal developer-portal front-end Relates to front end issues marketplace Relates to the Marketplace task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #8392 #8059 improves installations handling reapit/foundations
1 participant
@willmcvay