Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a ‘Developer’, I want to review my pending revision and have the option to cancel it #635

Closed
HollyJoyPhillips opened this issue Mar 16, 2020 · 0 comments · Fixed by #704
Assignees
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace

Comments

@HollyJoyPhillips
Copy link
Contributor

HollyJoyPhillips commented Mar 16, 2020

Given that I am a ‘Developer’, when I have submitted a revision on my app, I should then have the option to see what revisions are awaiting approval and to also have the option cancel that revision if required

Summary: Currently when a Developer makes a revision to their app, they cannot see what revisions are awaiting approval or have the option to cancel the revision. App revisions can only be ‘Rejected’ or ‘Approved’ by an ‘Admin’. In some instances, a ‘Developer’ may wish to make additional changes or cancel the current changes so we should present what is waiting to be approved and a ‘Cancel Pending Revision’ option.

Task: To display in a modal the revision(s) that have been submitted and add a ‘Cancel Pending Revisions’ button

  • When an app has ‘pendingRevisions’ set to true. We should enable the ‘Pending Revisions’ button (currently disabled) in the Developers Portal
  • When clicked, it should open a modal displaying the Apps details and highlighting the changes that have been made using the same diffing functionality as we do in the ‘Admin Portal’ to show what is waiting to be approved. All fields should be locked (as is on the Admin portal (https://dev.marketplace.reapit.cloud/admin/approvals)
  • Add a ‘Cancel Pending Revisions’ button (
  • When clicked, present confirmation of cancellation
    Modal Title: Please confirm
    Text: Are you sure you wish to cancel any pending revisions for this App?
    Buttons: ‘Yes, proceed’ and ‘Cancel’
  • Should post to '/apps/{id}/revisions/{revisionId}/reject' with Developers Email, Name (obtained through the login session) and set rejectionReason as 'Developer Cancelled'
  • When confirmed (Yes, Proceed), present success message
  • Success message wording: All pending revisions for this app have been cancelled. You can now use the ‘Edit Detail’ option to make any additional changes as required.
    Button ‘Back to App’ should close the success modal
  • The ‘Edit Detail’ button should be present again

Current UI when a revision is pending approval:
image

Mockup of new UI:
image

When 'Pending Revision' is clicked:
image

When ‘Cancel Pending Revision’ is clicked, confirmation message mock up:
image

When ‘Yes, proceed’ is clicked, present ‘Success Message’, mock up below:
image

@HollyJoyPhillips HollyJoyPhillips added feature New feature or request marketplace Relates to the Marketplace front-end Relates to front end issues labels Mar 16, 2020
@nphivu414 nphivu414 self-assigned this Mar 20, 2020
nphivu414 pushed a commit that referenced this issue Mar 20, 2020
nphivu414 pushed a commit that referenced this issue Mar 23, 2020
nphivu414 pushed a commit that referenced this issue Mar 24, 2020
nphivu414 pushed a commit that referenced this issue Mar 24, 2020
nphivu414 pushed a commit that referenced this issue Mar 25, 2020
nphivu414 pushed a commit that referenced this issue Mar 25, 2020
* feat: #635:Developers can review and cancel their pending revisions
nphivu414 pushed a commit that referenced this issue Apr 29, 2020
* feat: #635:Developers can review and cancel their pending revisions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request front-end Relates to front end issues marketplace Relates to the Marketplace
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants